On 09.01.2011 10:46, Uli Schlachter wrote:
> Am 09.01.2011 00:39, Sanjuro Makabe wrote:
> 
> 
>> On 08.01.2011 22:31, Uli Schlachter wrote:
>>> Am 08.01.2011 22:21, Sanjuro Makabe wrote:
>>> [...]
>>>> It seems to me that although the
>>>> minimized client is focused (as shown by the tasklist) every new modkey
>>>> + n press goes directly to another client.
>>>
>>> Uhm, you shouldn't be able to focus a minimized key. Having keyboard input 
>>> go to
>>> a window that you don't see would be really awkward.
>>>
>>> What do you do to focus the minimized window?
> 
>> You are right. I didn't quite think about how I was able to focus
>> minimized windows. Actually I did click the tasklist entries.
> 
>>>
>>>> My only way of getting around this is killing awesome and
>>>> all the minimized clients together... What is the intended way of
>>>> un-minimizing clients? What could be wrong? Hoping for some help...
>>>
>>> When you use the mouse to click on the tasklist entry of some client 
>>> (=focusing
>>> that client), the client will be unminimized. Since there is no way to 
>>> select a
>>> minimized client via the keyboard, it cannot be unminimized with any 
>>> keybindings.
> 
>> I understand. Then for some reason the raising/unminimizing part does
>> not work. I can click entries of minimized windows but nothing happens
>> aside from them being shown as having focus (which they obviously don't
>> have).
> 
> Whoops, sorry.
> I broke this three months ago and no one noticed until now. Focusing the 
> client
> by clicking on its tasklist empty should work again now.

Yeah that did the trick. Thank you!
I think minimizing/unminimizing is normally no part of the usual tiling
wm workflow, therefore no one noticed this.

> 
> Cheers,
> Uli
> 
> commit 6494540b0c0abd2b293269427bbe404fdd0febf2
> Author: Uli Schlachter <[email protected]>
> Date:   Sun Jan 9 10:40:42 2011 +0100
> 
>     Unban clients when they are focused
> 
>     In commit 3dbf89c I removed a client_unban() in the code path for focusing
>     clients. The idea was that client focusing is now done after rebanning, so
>     that it should already be visible by the time this code is executed.
> 
>     However, minimized clients obviously don't get unbanned, So we have to 
> call
>     client_unban() here to make sure the client is unminimized.
> 
>     Signed-off-by: Uli Schlachter <[email protected]>
> 

-- 
To unsubscribe, send mail to [email protected].

Reply via email to