-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi,
Am 20.03.2011 17:20, Chris Newton wrote: > [..] So I did a little digging and came up with this > quite small patch that adds a flag to the exit signal which indicates > if its an exit for a restart or an exit for a real shutdown of > awesome. thanks for the patch. The idea certainly doesn't seem bad, but I got some comments about this. First, please use git and send the result of "git format-patch origin/master.." to the mailing list. That way git tracks you as the author. To clone the git tree, use "git clone git://git.naquadah.org/awesome.git". Here is a random howto that came to my mind for this: http://www.x.org/wiki/Development/Documentation/SubmittingPatches Now, about the patch itself... > diff -ru awesome-3.4.9.org//awesome.c awesome-3.4.9/awesome.c > --- awesome-3.4.9.org//awesome.c 2011-01-17 04:38:13.000000000 -0700 > +++ awesome-3.4.9/awesome.c 2011-03-20 08:42:04.789788001 -0600 > @@ -62,14 +62,15 @@ > /** Call before exiting. > */ > void > -awesome_atexit(void) > +awesome_atexit(bool restart) > { [...] > > - signal_object_emit(globalconf.L, &global_signals, "exit", 0); > + lua_pushboolean(globalconf.L, restart); > + signal_object_emit(globalconf.L, &global_signals, "exit", true); ^^^^ This is the number of arguments for the signal. You want "1" instead of "true". Cheers, Uli - -- The Angels have the phone box! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBCAAGBQJNhjtPAAoJECLkKOvLj8sGVk8H/3yx7zutB13rddFx7gY79FEe lq5IrQQBaEPaAVyCr2t4T9xFHW86INJPtjesIvkv9FlLaWCzUGMeBZrvbtyXay8h SSlwl7cWp8xXD7HjUGRvTJyLbXaZgU36AqoWmnxQXVHa4LlpG/jNqp/JtKx0ySxH tqwBOYpTkSxkW4RFHHyFLKi5EzcFyYqikF6j/dI40gpMmUk5pMczRA7E0B/V+Myc sw3mYtDHEDIjo7tMM4g/3V9chukH/IZT8OcOi4V6p56N2rIGT6ho4fPFpnw+dQ4K BPGrmSmm92OMpMg1hNlmZrsiIpDLIZtnxJC+hrfMCoRF7enWkITakaMzjqAH+qM= =bBxa -----END PGP SIGNATURE----- -- To unsubscribe, send mail to [email protected].
