On 04.10.2011 17:59, David Palacio wrote: > On Tue, Oct 04, 2011 at 10:19:34AM +0200, Uli Schlachter wrote: >> On 04.10.2011 07:32, David Palacio wrote: >>> On Sun, Oct 02, 2011 at 02:11:18PM -0500, David Palacio wrote: >>>> I am using Awesome as the window manager for my KDE desktop. I would like >>>> to >>>> set different desktops per Awesome tag. I use client:tags({tags}) to set on >>>> which tags should the desktop be visible. But that does not work as >>>> expected as >>>> the desktops are still visible in all tags. Is there a way to make a >>>> window of >>>> type desktop visible only on certain tags? >>> >>> I patched Awesome to let desktop windows be visible on certain tags. >>> What are your thoughts on these changes? >> >>> Description: Taggable desktops >>> This patch allows windows of type Desktop to be visible only on certain >>> tags. >>> This works by removing the assumption that desktop windows are always >>> visible >>> (see diff in client.c). >> >> Ok. I checked EWMH and I have no clue why awesome was doing this. This code >> was >> added to awesome in commit 427679b0 which is the commit when support for >> _NET_WM_WINDOW_TYPE was added. >> >>> Other changes include: >>> * Returning an empty table of tabs when querying the tabs function. >>> (see second diff in client.c) >>> * Returning a table of clients excluding the desktop client when querying >>> the >>> tag clients. >>> (see diff in tag.c) >> >> Uhm, why? Desktop clients can be tagged, so why should they be hidden from >> tags? > Because the taglist widget will show "with clients focused/unfocused" state > if it has an unstickied desktop client. > > I do not like the client object lying about the tags it is tagged on so I > removed the change on client.c and instead patched taglist.lua to ignore > desktop clients. > > I kept the change on tag.c to keep the changes on taglist.lua simple. Also, > because tag.clients did not return desktop clients before these patches > either. > >> Also, please send a git formatted patch so that you are tracked as the >> patch's >> author. Thanks a lot! > > Attached.
Pushed, although I'm still not convinced. Wouldn't something like this solve the problem in a cleaner way? diff --git a/awesomerc.lua.in b/awesomerc.lua.in index fcfb333..ef8cc96 100644 --- a/awesomerc.lua.in +++ b/awesomerc.lua.in @@ -306,6 +306,8 @@ awful.rules.rules = { focus = true, keys = clientkeys, buttons = clientbuttons } }, + { rule = { type = "desktop" }, + properties = { skip_taskbar = true } }, { rule = { class = "MPlayer" }, properties = { floating = true } }, { rule = { class = "pinentry" }, Uli -- "Do you know that books smell like nutmeg or some spice from a foreign land?" -- Faber in Fahrenheit 451 -- To unsubscribe, send mail to awesome-unsubscr...@naquadah.org.