Hi,
sorry that it took me a while, I were (pretending to be?) busy.
On 19.11.2011 02:56, Majic wrote:
[..]
> So for the last time (hopefully), here are the patches in the order
> they should be applied:
>
> 1) 0001-Deduplicate-the-warn-in-in-color_init_unchecked.patch
> /* The color is given in RGB value */
> - if(!color_parse(colstr, len, &red, &green, &blue))
> + if(len == 0 || !color_parse(colstr, len, &red, &green, &blue))
> {
> - warn("awesome: error, invalid color '%s'", colstr);
> req.has_error = true;
> return req;
> }
So if len == 0, this won't warn any more at all, but fail silently?
> 2) 0001-Refine-RGB_-macros-use-RGB_16TO8-in-luaA_push_color.patch
The patch does a lot more than that. :-P
I dropped the following change and pushed the rest:
> - *red = (colnum >> 16) & 0xff;
> - *green = (colnum >> 8) & 0xff;
> + *blue = colnum & 0xff;
> + colnum >>= 8;
> + *green = colnum & 0xff;
> + colnum >>= 8;
> *blue = colnum & 0xff;
> psychon please just accept them, I think I'm going crazy. And this
> all was so simple, I should not have failed so many times. And now my
> fail will be immortalized in mailinglist history :(
You are going crazy? I thought you already were? :-P
> The 2 attached patches on this last message are the final and correct
> ones. And this time I compiled and ran awesome to test them. And that
> shall be what I do from now on. EVEN IF I CHANGE ONLY COMMENTS >8|
[...]
That's what she said.
Uli
--
"In the beginning the Universe was created. This has made a lot of
people very angry and has been widely regarded as a bad move."
--
To unsubscribe, send mail to [email protected].
