Good Morning,

On 31.10.2013 05:46, Andre Klärner wrote:
> On Wed 30.10.2013 20:28:32, Uli Schlachter wrote:
[...]
>> Having written this mail and re-reading it before sending it, I notice that 
>> you
>> mentioned awesome 3.4.15. A quick look confirms that 3.4 does not have this
>> feature. It was introduced in the following commit:
>>
>> commit 9393b2d1110b308edddf3255b5a001fe64f49478
>> Author: Julien Danjou <[email protected]>
>> Date:   Mon Sep 21 20:35:14 2009 +0200
>>
>>     screen: add index by output name (FS#361)
>>
>>     Signed-off-by: Julien Danjou <[email protected]>
> 
> Well, I think one should document this in the wiki. I think I read this bug
> report way back when I first searched for this. Unfortunately I seemingly
> missed the "fixed in 3.5 part".

Documented this in git. No idea if my explanation makes much sense.

http://git.naquadah.org/?p=awesome.git;a=commitdiff;h=29ecc6095f6f566757d17538635eb2b7674ed96f

>>> I tried to find the code responsible for creating the screens array, but it
>>> seems like I am not a really good C-reader. But if such a feature was
>>> available it would definately ease my day.
>>
>> Heh. :-)
>>
>> Look at screen.c, function luaA_screen_module_index(). This function is 
>> called
>> whenever you index the screen object. It's implementation is:
>>
[...]
> 
> Well, obviously this can't be found in 3.4's code (as I checked it out via
> apt-source..). But I am still very impressed.. there should be a how-to on
> reading source code.. ;)

No idea how such a how-to should look like. It seems like the problem here was
partly in our magic for implementing classes in lua. However, most of that is
part of lua already...

> Thanks a lot, I think it won't take long until I finally get around
> switching to 3.5.

Arnau once mentioned that 3.5.1 was uploaded to debian experimental, because it
didn't work for him. His bug report (FS#1155) was fixed with 3.5.2 and thus I
guess 3.5.2 might show up in unstable eventually...

[...]

Uli
-- 
If you ask me to debug your code, I'm going to mail you spiders.

-- 
To unsubscribe, send mail to [email protected].

Reply via email to