Hi, Omair,
see my comments below.
Omair Majid wrote:
Hi Artem,
Artem Ananiev wrote:
Hi, Omair,
I've just updated bug #6721088 and included the information about the
fix and the source of the problem. Do you prefer to push the fix into
workspace yourself? You/your company must have signed SCA for doing
that, and you also need a second reviewer from AWT group then.
Thanks for updating the bug report. I would love to push the fix myself.
I work for Red Hat which has signed the SCA. Is there a procedure for
asking for a second reviewer or should I use this mailing list?
Please, use this awt-...@openjdk alias for submitting an updated version
of the patch (with WindowDimensions comments?). I'll ask someone else
from AWT to review it.
Note, to push the changes into OpenJDK you need a valid mercurial user
(which is also the author of the corresponding revision) with the access
to AWT workspace. Do you have one or need any help with this?
Thanks,
Artem
As for isClientSizeSet() - it's pretty self-explanatory :) What kind
of additional comments do you suggest? Probably, something like this:
/**
* If isClient is true, the given rectangle is treated as a client
rect, otherwise as a whole window rect with insets included.
*/
public WindowDimensions(Rectangle rec, Insets ins, boolean isClient);
Yup, that looks great!
Cheers,
Omair
