Hi Piet,

On 04/15/2010 03:48 PM, Piet Blok wrote:
src/share/classes/java/awt/Component.java
2045                 if (peer instanceof LightweightPeer) {
2089                 if (peer instanceof LightweightPeer) {

I suggest using the isLightweight() method instead.

I followed the exact structure as found in the existing method getLocationOnScreen_NoTreeLock(). I regarded that existing code more or less as "sacred" and to be followed.

Still, I suggest to replace these with calls to the isLightweight() method since that is considered to be "the right" way to check whether a component is lightweight.

Otherwise I'm OK with the AWT part of the fix. Great work. Thanks!

--
best regards,
Anthony

http://www.pbjar.org/OpenJDK/6929295/webrev/

Reply via email to