Hi, Sean,

text components in XToolkit use Swing peers, so this change should better be reviewed on the swing-dev alias. To save everybody's time, I've asked Alex and Pavel from the Swing team (in CC) to take a look and they confirm the fix looks fine.

Did you consider creating a new regression test for this fix? I'm not sure it's easy to detect if caret is visible in the text component or not, though.

Thanks,

Artem

On 1/16/2012 7:08 AM, Sean Chou wrote:
Hi all,

    I made a patch for bug 7129742,
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129742 .
The webrev link is : http://cr.openjdk.java.net/~zhouyx/7129742/webrev.00/

    The solution is very simple, just set the cursor visible.

    Please have a look and give some comments. Thanks.

--
Best Regards,
Sean Chou

Reply via email to