Hi Mike,
Thanks for the review. Here's an updated fix:
http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.1/
--
best regards,
Anthony
On 2/4/2012 3:12 AM, Mike Swingler wrote:
On Feb 3, 2012, at 5:22 AM, Anthony Petrov wrote:
Hello,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7142120 at:
http://cr.openjdk.java.net/~anthony/x-14-splashScreen-7142120.0/
The fix is fairly simple: use NSScreen -frame instead of -visibleFrame. In this
case the splash screen is positioned in the geometrical center of the screen.
Visually this looks less pleasant (we may want to file an RFE in the future),
but makes tests happy which is what we need right now.
All the failing tests now pass well with this fix applied.
Also [NSScreen mainScreen] gives you the screen that the "main" (aka "active") window is
on. You really should use the 0'th screen to get the "primary" screen with the menu bar and the
Dock.
Regards,
Mike Swingler
Apple Inc.
