On 3/29/2012 4:34 PM, Artem Ananiev wrote:

On 3/27/2012 5:16 PM, Anthony Petrov wrote:
Hi Artem,

Thanks for the review.

On 3/26/2012 5:26 PM, Artem Ananiev wrote:
1. Should we deliverZoom() after the call to setBounds()?

The order between the calls preserves the order between the
MAXIMIZE/RESIZE events received from the native system when using the
native NSWindow.zoom() method.


2. Will this fix work in the case when an undecorated window goes
fullscreen and then changes its bounds while being in the fullscreen
mode?

The full screen mode isn't an extended state. Also, my fix doesn't
affect the setBounds() implementation, so I don't see how this issue may
be relevant to this fix. Please elaborate.

window.setBounds(x, y, width, height)
graphicsDevice.setFullscreenWindow(window)
window.setBounds(newX, newY, newWidth, newHeight)
graphicsDevice.setFullscreenWindow(null)

I meant setExtendedState(MAXIMIZED), not setFullScreenWindow(), of course... I'm fine with the changes if the sequence of calls above gives a reasonable result.

Thanks,

Artem

What will be the window bounds in this case?

Thanks,

Artem

--
best regards,
Anthony


Thanks,

Artem

On 3/23/2012 7:49 PM, Anthony Petrov wrote:
Hello,

Please review a fix for
http://bugs.sun.com/view_bug.do?bug_id=7124428 at:

http://cr.openjdk.java.net/~anthony/8-12-setExtendedStateUndecorated-7124428.0/




This is a direct forward-port of the same fix from 7u4.

More details:
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003630.html




--
best regards,
Anthony

Reply via email to