Looks good to me. Cheers, Mike Swingler Apple Inc.
On Apr 4, 2012, at 7:00 AM, Anthony Petrov wrote: > Here's a fix that wipes out all traces of the grow box: > > http://cr.openjdk.java.net/~anthony/8-19-frameMinSize-7124553.1/ > > -- > best regards, > Anthony > > On 4/4/2012 1:50 PM, Artem Ananiev wrote: >> On 4/3/2012 4:22 PM, Anthony Petrov wrote: >>> Hi Artem, >>> >>> May I consider the fix reviewed, or do you (and anyone else interested) >>> have any further questions/suggestions? >> I still think that the code to support 10.6, which will a legacy OS at the >> moment when JDK8 is released, should not be fw-ported from 7u to 8. >> Thanks, >> Artem >>> -- >>> best regards, >>> Anthony >>> >>> On 3/27/2012 4:32 PM, Anthony Petrov wrote: >>>> Hi Artem, >>>> >>>> Thanks for the review. >>>> >>>> Reading through macosx-port-dev@ mailing list I observe a lot of users >>>> who (try to) use Oracle JDK for Mac on Snow Leopard systems, and I see >>>> nothing wrong with that as long as it is runnable on those systems. At >>>> least at this exact moment we don't have a strong reason to drop >>>> support for (this is a wrong word here, rather "ability to run on") >>>> Mac OS X 10.6. When there's some code that ultimately won't run on >>>> Snow Leopard and we drop the support completely, then we may remove >>>> this grow box stuff as well. But currently it doesn't hurt anyone. >>>> >>>> So for now I would like to leave GROW_BOX_SIZE and friends as they >>>> are. Is this OK? >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 3/26/2012 5:15 PM, Artem Ananiev wrote: >>>>> >>>>> Looks fine, but... Is the new constant GROW_BOX_SIZE about pre-Lion >>>>> window resize box at the bottom-right corner of the window? I doubt >>>>> [Snow] Leopard will be in the list of supported platforms for JDK8, >>>>> so it doesn't make any sense to have code specific to this resize box >>>>> in the workspace. >>>>> >>>>> Thanks, >>>>> >>>>> Artem >>>>> >>>>> On 3/23/2012 9:25 PM, Anthony Petrov wrote: >>>>>> Hello, >>>>>> >>>>>> Please review a fix for >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124553 at: >>>>>> >>>>>> http://cr.openjdk.java.net/~anthony/8-19-frameMinSize-7124553.0/ >>>>>> >>>>>> This is a direct forward-port of the same fix from 7u4. >>>>>> >>>>>> More details: >>>>>> http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003101.html >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony
