Anthony Petrov wrote:
On 5/15/2012 5:59 PM, Dmitry Cherepanov wrote:
Thanks for fixing this, minor comment:
- 166 [reps release];
Looks fine to me as [NSMutableArray arrayWithCapacity:] returns
auto-released object.
- 117 [imageRep release];
We should probably keep this 'release' as, looks like, it corresponds
to "[NSBitmapImageRep alloc] ..." from CImage_CreateImageRep.
"I've learned something today!" :)
Indeed. A good catch! Thank you. Here's an updated fix:
http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.1/
Looks fine to me, thanks! :)
--
best regards,
Anthony
Thanks,
Dmitry
Anthony Petrov wrote:
Hi Dmitry,
Please review a fix for
http://bugs.sun.com/view_bug.do?bug_id=7168851 at:
http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/
--
best regards,
Anthony
