Verified, thanks. On Wed, May 23, 2012 at 12:50 PM, Charles Lee <[email protected]>wrote:
> Hi Sean, > > The patch is committed @ > > Changeset: cac4daf60283 > Author: zhouyx > Date: 2012-05-23 12:37 +0800 > URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cac4daf60283 > > 7170996: IME composition window does not disappear when file dialog is closed > : Japanese WinXP > Reviewed-by: art, bagiras > > Please verify it and thank you all for reviewing. > > > On 05/23/2012 11:13 AM, Sean Chou wrote: > > Hi Charles, > > I reported a new bug > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170996 , it might > take some time to be valid. > > On Tue, May 22, 2012 at 5:46 PM, Charles Lee > <[email protected]>wrote: > >> Hi Sean, >> >> 7071248 has been used (apparently). Would you please create a new CR? >> >> >> On 05/22/2012 12:32 PM, Sean Chou wrote: >> >>> Hi Oleg and Artem, >>> >>> Thank you! I'll find Charles to help commit it. >>> >>> On 2012/5/22 1:48, Oleg Pekhovskiy wrote: >>> >>>> Hi Sean et all, >>>> >>>> I checked that one-liner on XP and looked like it's ok. >>>> >>>> Thanks, >>>> Oleg >>>> >>>> On 05/18/2012 17:46, Artem Ananiev wrote: >>>> >>>>> Hi, Oleg, >>>>> >>>>> could you take a look at this short fix, please? I'm not an expert >>>>> here, but the changes look really fine and harmless to me. >>>>> >>>>> Thanks, >>>>> >>>>> Artem >>>>> >>>>> On 5/17/2012 7:17 AM, Sean Chou wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> When verifying bug 7071248, I found the problem is not resolved, >>>>>> because the original >>>>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) >>>>>> is >>>>>> not complete. It lacks another one line change >>>>>> in src/windows/native/sun/windows/awt_Component.cpp . >>>>>> The problem is only seen on windowsXP, but as the patch is half >>>>>> committed, I think it's better to make it complete. >>>>>> The webrev to complete the patch: >>>>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/ . Please take >>>>>> a look. >>>>>> >>>>>> >>>>>> original changeset: >>>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4 >>>>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248 >>>>>> >>>>>> >>>>>> -- >>>>>> Best Regards, >>>>>> Sean Chou >>>>>> >>>>>> >>>> >>> >> >> -- >> Yours Charles >> >> > > > -- > Best Regards, > Sean Chou > > > > -- > Yours Charles > > -- Best Regards, Sean Chou
