On May 23, 2012, at 5:26 PM, Leonid Romanov wrote:

> Hi, 
> Please review a fix for  7168062: [macosx] Java processes on Mac should use 
> Oracle Java branded icons. This is about using new Oracle Java branded icon 
> as the default icon for Java apps instead of the Apple supplied icon found in 
> /System/Library/Frameworks/JavaVM.framework.
> I've discussed this bug with Artem Ananiev and we decided that the best way 
> to do it is to convert icon file to .h file with icon data as an array of 
> bytes and then include this .h file where icon data is needed. So, we 
> basically compile in icon data into the binaries. 

That seems like overkill to me. Can't we just put the .icns in the JRE 
(Contents/Home/jre/lib/images) and load it from there? What are we guarding 
against by putting it into a .h file?

-- Scott

----------------------------------------
Scott Kovatch
[email protected]
Santa Clara/Pleasanton, CA

Reply via email to