On 5/31/2012 8:20 PM, Scott Kovatch wrote:
I think what Artem is saying is that if the application is bundled, and CFBundleName
is set, it should take higher priority than JAVA_MAIN_CLASS_<pid>.
If that is what you are saying, Artem, I agree. :-)
Yes, exactly, thanks for clear wording, Scott :)
We're straying away from the original review, though.
Since we touch that code anyway, we may want to extend the fix to make
JAVA_MAIN_CLASS_<pid> of lower priority instead of filing a new bug for
that.
Thanks,
Artem
-- Scott
On May 31, 2012, at 8:30 AM, Artem Ananiev<artem.anan...@oracle.com> wrote:
Hi, Leonid,
shouldn't app name set in the bundler be of higher priority than
JAVA_MAIN_CLASS_<pid> value, set by Java launcher?
Thanks,
Artem
On 5/29/2012 8:59 PM, Leonid Romanov wrote:
Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check
for the "apple.awt.application.name" property. If this property hasn't been set, we try to
get the app name from the JAVA_MAIN_CLASS_<pid> environment variable, which is used to pass
the name of a Java class whose main() method was invoked by the Java launcher code to start the
application. If JAVA_MAIN_CLASS_<pid> hasn't been set, then as the last resort we try to get
the app name from the bundle.
On 28.05.2012, at 19:35, Artem Ananiev wrote:
On 5/28/2012 6:06 PM, Leonid Romanov wrote:
Hi,
The problem with the application name is that the app in question uses
"com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu
understanding is that we don't support this property in OpenJDK.
OK, fine. Is the application name set correctly when it is passed from app
bundle or as -Xdock:name?
Thanks,
Artem
On 28.05.2012, at 16:46, Artem Ananiev wrote:
Hi, Leonid,
the fix looks fine. Is the application name issue (also mentioned in 7159381)
addressed in another fix?
Thanks,
Artem
On 5/24/2012 5:23 PM, Leonid Romanov wrote:
Hi,
Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java
Application Category. The problem here is that we ignore the fact that for the
bundled app its icon might be specified via Info.plist file. In this case OS X
sets the icon for us, so we don't have to do anything.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
Webrev: http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
Thanks,
Leonid.
