The fix looks fine to me.
--
best regards,
Anthony
On 6/1/2012 9:31 PM, Dmitry Cherepanov wrote:
Here's a patch for the deadlock in GTKEngine.native_switch_theme
Bug report - http://bugs.sun.com/view_bug.do?bug_id=7123957
The fix partially reverts the changes for 6913179 [1] so that we don't
wrap 'g_main_context_iteration' with
'gdk_threads_enter'/'gdk_threads_exit' as 'g_main_context_iteration'
takes care of locks (GTK lock functions aren't reentrant and try to get
lock again causing dealock).
Webrev - http://cr.openjdk.java.net/~dcherepanov/7123957/webrev.0/
Thanks,
Dmitry
[1]
http://hg.openjdk.java.net/jdk7/awt/jdk/diff/5eccce06fed5/src/solaris/native/sun/awt/swing_GTKEngine.c
