Hi, Sean,
Alan is right, this request should be sent to 2d-dev, so I'm adding this
mailing list to CC and moving awt-dev to BCC.
The changes in StrikeCache look fine to me. I would just replace
PrivilegedAction<Object> with PrivilegedAction<Void>, so it is instantly
clear that the returned value is discarded.
As for Disposer changes... I'm not an expert in generics in Java and
can't provide any comments for <?> :)
Thanks,
Artem
PS I'm not a member of Java2D group and can't review/approve fixes to
Java2D-related files like StrikeCache and Disposer.
On 6/18/2012 6:48 AM, Sean Chou wrote:
Hello awt-dev guys,
I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
src/share/classes/sun/java2d/Disposer.java) to use generic type, but I'm
not sure if I modified too much. Especially I changed the return type of
Disposer.getQueue from ReferenceQueue to ReferenceQueue<Object> .
The webrev is: http://cr.openjdk.java.net/~zhouyx/OJDK-389/webrev.00/
The mail was sent to core-libs and there are some comments from
David Homles and Rémi Forax.
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010103.html
Please take a look.
||||
--
Best Regards,
Sean Chou
