Hi, Artem
As I have mentioned in review description, we can keep .html file and
runTest2() method commented in the BigFont.java if somebody wishes to
run it manually (e.g. when a failure happens). The .html file and the
method were kept in openjdk 7 regression testsuite. Or you think we
don't need to keep it?
Konstantin
On 04.06.2012 17:24, Artem Ananiev wrote:
Hi, Konstantin,
since you have replaced "@run applet" in .html with "@run main" in
.java, does it also make sense to remove .html at all? Alternatively,
you can keep the test as applet one, but mark it manual (@run
applet/manual).
BTW, copyright header dates should be updated to "2008, 2012", not
"2008, 2011".
Thanks,
Artem
On 5/31/2012 5:59 PM, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
6868690 TEST: java/awt/FontClass/CreateFont/BigFont.java test should be
modified in jdk7&8 to run via jtreg
The webrev is http://cr.openjdk.java.net/~serb/6868690/webrev.00/
The test in the current state affects a whole session if it's executed
under jtreg. It was fixed already by the implemented modifications in
1.7.0 that are used as a base for modifications applicable for 1.8.0
also. There is not risk are seen if the test be updated in jdk8 repo.
The current fix is identical to already pushed fix for jdk 7.
The test works in the automatic invocation (under jtreg) without
bigfont.html file involvement. The only possible reason we may keep it
(bigfont.html) for is - the test can be used in both the manual and
automatic invocations. It include two methods runTest1() & runTest2().
runTest2() is commented in the BigFont.java file as it's too "risky" to
execute it in the automatic mode from the the applet environment. But it
(runTest2()) is still valid for the manual invocation just for
"legacy/coverage" reason to be executed under applet environment that is
more challenging. As mentioned bigfont.html does not work in automatic
invocation, but it can work if somebody decide to run the test manually
(runTest2()) under applet environment.
Thanks,
Konstantin
