Hi, Pavel.
Thanks for review. See comments inline
12.07.2012 20:26, Pavel Porvatov wrote:
Hi Sergey,
The fix looks good. Could you please remove unnecessary code from the
test like:
1. @run main/othervm bug7170657
done
2. The "FAILED" field: you can throw exception from the "fail" method
In this case we skip part of the test. Useful for debug.
3. What is the reason to use final here: "public final class"?
I do not think that someone will want to be inherited from it. I just
make all classes final by default.
New version of the fix:
http://cr.openjdk.java.net/~serb/7170657/webrev.01/
Regards, Pavel
Hi Everyone,
Please review the fix.
Bug in SwingUtilities.convertMouseEvent().This method does not
convert extended state of the event.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657
Webrev can be found at:
http://cr.openjdk.java.net/~serb/7170657/webrev.00
--
Best regards, Sergey.
