On 7/20/2012 5:28 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Can we remove these checks from the peers and move them to
TextComponent.setText()?
I see. Could you review the updated fix?
The empty text check is removed from the LWTextAreaPeer an
XTextAreaPeer and moved to the TextComponent.
webrev: http://cr.openjdk.java.net/~alexsch/7184365/webrev.01/
Thanks,
Alexandr.
20.07.2012 17:05, Alexander Scherbatiy wrote:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184365
webrev: http://cr.openjdk.java.net/~alexsch/7184365/webrev.00/
The failed test expects that TextListener is not invoked after
changing empty text to empty for the TextArea
and is invoked for the TextField.
After switching the EDIT control to RICHEDIT on windows for the
TextField the TextListener listener is not invoked for both TextField
and TextArea in this case.
To be consistent with other platforms the fix:
- Moves the checking for new empty text from the LWTextAreaPeer to
LWTextComponentPeer on Mac OS X
- Adds the empty text checking to the XTextFieldPeer (the
XTextAreaPeer class has already has one) on Linux
Thanks,
Alexandr.
