Updated webrev can be found at
http://cr.openjdk.java.net/~kizune/7177144/webrev.02
See comments inside.
On 8/10/12 17:11, Sergey Bylokhov wrote:
10.08.2012 16:26, Alexander Zuev wrote:
Hello,
please review my fix for CR 7177144: [macosx] Drag and drop not
working (regression in 7u6)
I still tink we shouldn't move the instanceof check to the earlier
stage since this check may be costly
so it should not be performed unless other possibilities are ruled
out by the less expensive checks.
At least one of them can be moved from coalesceMouseEvent to
coalesceEvent
if (e instanceof MouseEvent && !(e instanceof
SunDropTargetEvent)) {
}
Ok, fixed.
in cacheEQItem() it executes almost always. Why we should not cache
these events? This fix affects all platforms it should?
Because most of the SunDropTargetEvents are synchronous and if we drop
the new one without calling consume() or
processing it then DnD may simply lock. I have no idea why this does not
happen more often but we can't afford to
coalesce these events. Every incoming SunDropTargetEvent should go
trough the normal processing.
Bug description is:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177144
Webrev can be found here:
http://cr.openjdk.java.net/~kizune/7177144/webrev.01
With best regards,
Alex
