Hi Anton,

After deserialization completes, the components in the 'component' collection must all share the same graphics configuration as its parent container (which is being deserialized). While your fix resolves the NPE, it doesn't yet sets up the child components with the correct graphics configuration after the 'component' collection has been populated which children during deserialization. I think we should probably add a deferred call to updateGraphicsData() somewhere at the readObject() method.

Also, should this issue be fixed for JDK 8 first, and then ported back to JDK 7u?

--
best regards,
Anthony

On 08/24/12 21:36, Anton Litvinov wrote:
Hello,

Please review the following fix for a bug.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193219
Webrev: http://cr.openjdk.java.net/~alexp/7193219/webrev.00

For details on this bug please look at "Evaluation" field on a web page
of this bug. The provided webrev contains both a fix and a corresponding
unit-test. Also before publishing this webrev all unit-test from the
"java.awt" and
"javax.swing" swing related to serialization and usage of
"GraphicsConfiguration" class were run and no negative changes were
observed comparing the results of tests' runs on JDK with and without
patch represented by this webrev.

Thank you,
Anton

Reply via email to