Hi, Anthony
See my comments inline
On 28.08.2012 16:42, Anthony Petrov wrote:
Hi Konstantin,
I think you should modify the copyright headers in each file. The
files are no longer proprietary/confidential. .sh and makefiles should
also include a copyright header. Please use existing source files in
the open repository as a template for the header.
test/java/awt/JAWT/MyCanvas.java
52 f.show();
Please replace this with f.setVisible(true);
53 robot.delay(10000);
I think 10 seconds is kind of too long. It might have been relevant
for Java 1.4, but now I think 5 seconds should be pretty much enough
for every modern system.
test/java/awt/JAWT/JAWT.sh
137 case "$OS" in
138 Windows* | CYGWIN* )
139 cp ${TESTJAVA}${FS}jre${FS}bin${FS}jawt.dll .
140 ;;
141 esac
Why is this necessary? This must be a bug in JDK if the library still
needs to be copied to the current directory on Windows. Could you
verify if the test still works w/o copying the dll? It must, actually.
I cannot verify it on JDK 8 (Windows only issue, Solaris and Linux work
fine) because on Windows this test compiles only with JDK 1.4.2 fcs b28!
Even if I use JDK 1.4.2 u39 b02, I have the following compiler error:
link -nologo -dll -out:mylib.dll myfile.obj gdi32.lib user32.lib
C:/jdk/j2sdk1.4.2_39b02\\lib\\jawt.lib
Creating library mylib.lib and object mylib.exp
myfile.obj : error LNK2019: unresolved external symbol
__imp__JAWT_GetAWT@8 referenced in function _Java_MyCanvas_paint@12
mylib.dll : fatal error LNK1120: 1 unresolved externals
NMAKE : fatal error U1077: '"C:\\Program Files (x86)\\Microsoft Visual
Studio 11.0\\VC\\BIN\\link.EXE"' : return code '0x460'
It seems there is no "__imp__JAWT_GetAWT@8" in jawt.lib since 1.4.2 fcs...
--
best regards,
Anthony
On 8/27/2012 8:29 PM, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
7190587 Open source and jtreg'ify JAWT regression test
Test was modified in to be run with jtreg.
The webrev is http://cr.openjdk.java.net/~kshefov/7190587/webrev.00/
Thanks,
Konstantin
