Hi Martijn,
src/share/classes/java/awt/Window.java:
1999 @SuppressWarnings("fallthrough")
2016 case WindowEvent.WINDOW_STATE_CHANGED:
2017 processWindowStateEvent((WindowEvent)e);
2018 default:
2019 break;
It looks like the only fallthrough here is the one at lines 2016-2019,
which can easily be eliminated by adding a break statement just before
the default branch. This would also eliminate the need for the
@SuppressWarnings annotation. Also, the default branch can be deleted
altogether, I guess.
Otherwise the fix looks fine to me.
--
best regards,
Anthony
On 09/15/12 16:17, Martijn Verburg wrote:
Hi all,
Artem Ananiev very kindly raised bugs and a webrev for the patches
sent in from a Bugathon we ran back in April (patches have been tested
against latest source tree).
The bug numbers are:
AWT:
7196567: [Bugathon] Reduce the number of javac warnings in AWT
7196568: [Bugathon] Reduce the number of javac warnings in
dragndrop/datatransfer
7196570: [Bugathon] Reduce the number of javac warnings in applets
A11Y:
7196569: [Bugathon] Reduce the number of javac warnings in accessibility
The corresponding webrevs are at:
http://cr.openjdk.java.net/~art/Bugathon-2012/webrev.awt/
Thanks to Artem, Stuart and Phil for helping me navigate through the
AWT/2D waters :-)
Cheers,
Martijn
