Hi Alexander,

I have no expertise in key handling code, but technically the fix looks good.

I'd only suggest to add a delay after the last keyRelease() call and before checking the value of 'state' in the test to ensure that everything is processed as expected even if the Robot sends events asynchronously.

--
best regards,
Anthony

On 9/18/2012 5:57 PM, Alexander Scherbatiy wrote:

bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199180
webrev: http://cr.openjdk.java.net/~alexsch/7199180/webrev.00/

Key events which have marked text are processed by the interpretKeyEvents method and so they are filtered for the deliverJavaKeyEventHelper method. However we need to process dead key events which also set marked text flag to generate dead key pressed event.

Thanks,
Alexandr.

Reply via email to