The fix looks good. Just one suggestion to the style:
src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java
163 if(testChar == 0){
Please insert spaces before '(' and after ')'. No need to resend a new
webrev with this change.
--
best regards,
Anthony
On 10/11/12 18:17, Alexander Scherbatiy wrote:
This is a direct backport of the fix from the JDK 8 to JDK 7u12
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199180
webrev: http://cr.openjdk.java.net/~alexsch/7199180/webrev.01/
Key events which have marked text are processed by the
interpretKeyEvents method and so they are filtered for the
deliverJavaKeyEventHelper method.
However we need to process dead key events which also set marked text
flag to generate dead key pressed event.
- The JDK crash is fixed
The TISGetInputSourceProperty returns nill property for the dead key
combination in the Chinese Pynyin.
The fix ignores the dead keys which does not have the input source
property.
- The realSync() is added before the state checking in the test
- The test is renamed to have the first capital letter.
Thanks,
Alexandr.
