Yes, in fact the original webrev approved by art and ant for 7u10
backport has included the file. It's just been missed in final `hg
commit` due to an absent `hg add` for this file.
Leonid: please consider this fix with the new file reviewed by AWT.
--
best regards,
Anthony
On 11/7/2012 7:13 PM, Seán Coffey wrote:
Is the new file the same as that added to JDK 8 ?
http://hg.openjdk.java.net/jdk8/tl/jdk/file/0e007aa6f9db/src/share/classes/sun/awt/TimedWindowEvent.java
If so, can we have an awt reviewer review/approve the change? (You'll
need to add a reviewer to the 8002362 changeset Leonid)
Please ensure no other files have been omitted and that jdk7u-dev will
build & test ok with this change.
Your push is approved for jdk7u-dev but subject to awt review and build
results.
I see Anthony has just reviewed.
Regards,
Sean.
On 07/11/2012 15:05, Leonid Romanov wrote:
Would be k if I just push missing file without sending a review? I
forgot to do "hg add" on it when committing the fix into my local repo.
On Nov 7, 2012, at 5:43 PM, Anthony Petrov <[email protected]>
wrote:
I just filed 8002362. Leonid, please take a look asap.
--
best regards,
Anthony
On 11/7/2012 4:44 PM, Seán Coffey wrote:
This is related to the 7185280 fix that was pushed yesterday.
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6f4e5e8f178d
Leonid (or team) - can you log a P1 bug and fix asap ?
All code changes need to be build and tested before pushing.
Regards,
Sean.
On 07/11/2012 12:07, Anthony Petrov wrote:
(bcc'ing core-libs-dev@)
Looks like this is related to 6981400. I'm CC'ing Anton to take a
look at it.
--
best regards,
Anthony
On 11/7/2012 2:58 PM, Weijun Wang wrote:
I've just synced with jdk7u-dev and now it does not build.
symbol: class TimedWindowEvent
location: class SunToolkit
../../../src/share/classes/sun/awt/SunToolkit.java:472: error:
cannot find symbol
TimedWindowEvent twe = (TimedWindowEvent)nested;
^
symbol: class TimedWindowEvent
location: class SunToolkit
It seems there is no class called TimedWindowEvent.
I am building the jdk repo only.
Thanks
Max
