Hi, Anthony.
Since this check is not necessary for the fix, I just drop it.
Updated webrev:
http://cr.openjdk.java.net/~serb/7193214/webrev.01/
GUI jck tests passed.

06.11.2012 19:34, Anthony Petrov wrote:
Hi Sergey,

Generally I'm fine with nativeSetNSWindowStyleBits updating the bits only when they've changed. Did you run AWT regression tests for top-level areas (both open and closed) to make sure there's no regressions associated with this change? Shouldn't we force reinstalling some style bits when e.g. a window gets hidden and then subsequently shown again?

--
best regards,
Anthony

On 11/6/2012 6:54 PM, Sergey Bylokhov wrote:

Hi Everyone,
Please review the fix.
In the fix, unnecessary calls were removed from setResizable(), also now we take into account zoom state in the setResizable() + plus small cleanup;

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193214
Webrev can be found at: http://cr.openjdk.java.net/~serb/7193214/webrev.00

--
Best regards, Sergey.


--
Best regards, Sergey.

Reply via email to