http://cr.openjdk.java.net/~kshefov/7147408/webrev.02/
<http://cr.openjdk.java.net/%7Ekshefov/7147408/webrev.02/>
On 08-Nov-12 16:44, Alexander Scherbatiy wrote:
On 11/7/2012 6:59 PM, Konstantin Shefov wrote:
I made modifications you suggested.
http://cr.openjdk.java.net/~kshefov/7147408/webrev.01/
<http://cr.openjdk.java.net/%7Ekshefov/7147408/webrev.01/>
Could you also fix the issue with the catched RuntimeException?
All others looks good for me.
Thanks,
Alexandr.
Konstantin
On 01-Nov-12 18:04, Alexander Scherbatiy wrote:
- The test needs to create and use Swing components only on EDT.
The same is for JApplet (see
http://docs.oracle.com/javase/tutorial/uiswing/components/applet.html).
In the same way the following variable initialization is not
correct because the JEditorPane is not created on the EDT:
private JEditorPane jep = new JEditorPane();
- The test fails with the compilation error: cannot find symbol
Util.blockTillDisplayed(jep);
Use the toolkit realSync() method instead:
SunToolkit toolkit = (SunToolkit) Toolkit.getDefaultToolkit();
...
toolkit.realSync();
Thanks,
Alexandr.
On 10/31/2012 1:58 PM, Konstantin Shefov wrote:
On 30-Oct-12 16:43, Anthony Petrov wrote:
Looks fine to me.
--
best regards,
Anthony
On 10/30/2012 3:51 PM, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
7147408 [macosx] Add autodelay to fix a regression test
The webrev is http://cr.openjdk.java.net/~kshefov/7147408/webrev/
It is suggested to move the test to open jdk.
Thanks,
Konstantin
