Minor comments:
1. In JTextComponent you need to override addNotify() to re-install
caret change listener.
2. X11InputMethod can't be referenced in sun.awt.im code (in fact, X11*
classes are absent on Windows at all).
Thanks,
Artem
On 1/18/2013 4:26 PM, Petr Pchelko wrote:
Hello, this is a reminder.
For your convenience:
7079260 : InputContext leaks memory
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079260
The new webrev is available here:
http://cr.openjdk.java.net/~serb/petr/7079260/webrev/
With best regards. Petr.
On Jan 10, 2013, at 12:49 PM, Petr Pchelko wrote:
Hello.
Sorry, I've forgot about licenses. I will add them before the push.
With best regards. Petr.
On Jan 9, 2013, at 4:38 PM, Petr Pchelko wrote:
Hello, here is the new version of the fix with the test attached.
While writing the test I have noticed some additional references which also
were not removed and could lead to a memory leak, so now the following
references are cleaned:
1. References from X11InputMethod which were reported in an original CR
2. References from CompositionAreaHandler
3. References from the Caret timer. It is not critical, as these references
were removed at the time of the next caret blink, however now it is cleaned
immediately.
The new webrev is available here:
http://cr.openjdk.java.net/~serb/petr/7079260/webrev/
Best, Petr.
On Dec 21, 2012, at 7:16 PM, Sergey Bylokhov wrote:
Hi, Petr.
It would be good to have appropriate testcase for this issue too.
21.12.2012 16:57, Petr Pchelko wrote
Hello,
Could you please review the fix for the issue:
7079260 : InputContext leaks memory
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079260
The webrev is available at:
http://cr.openjdk.java.net/~art/pchelko/7079260/webrev/
The memory leak component in the test, provided in the description of the bug
is still now collected with this fix, however now all the references are in
netbeans code, not AWT.
The fix was tested on Linux platform with toy apps and automatic tests related
to im.
Best, Petr.
--
Best regards, Sergey.
