Honestly, I have no idea why that was commented out. Perhaps we were debugging the support for the default menu stuff in com.apple.eawt.Application.setDefaultMenuBar(JMenuBar)? It was so long ago I honestly have no idea.
Regards, Mike Swingler Apple Inc. On Jan 29, 2013, at 9:52 AM, Leonid Romanov <[email protected]> wrote: > Looks like it was Mike Swingler who committed this, already commented code, > to the old repo. Adding him to CC. > > On Jan 29, 2013, at 8:06 PM, Anthony Petrov <[email protected]> wrote: > >> Hi Leonid, >> >> I see that the lines were commented out since the initial push of the MacOSX >> port code to the JDK repository. Could you please clone the old workspace >> (when we worked in a separate set of repositories) and investigate why were >> the lines commented out in the first place? >> >> PS. The fix looks fine and correct. But I'd like to make sure we don't >> remove a workaround for some other problem with this fix. >> >> -- >> best regards, >> Anthony >> >> On 1/29/2013 19:57, Leonid Romanov wrote: >>> Hi, >>> Please review a fix for 8007006 : [macosx] Closing subwindow loses main >>> window menus. The problem manifests itself when the global menu bar is used >>> and we change menu for an inactive window. In this case current global >>> menu gets replaced by the menu we set for the inactive window (or disappear >>> completely, if the inactive window menu was removed). >>> webrev: http://cr.openjdk.java.net/~leonidr/8007006/webrev.00/ >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007006 >>> Leonid. >>> >
