I've created a back-port issue 8013359. You may watch it on the
bugs.sun.com to get notified when it gets resolved (it should be
available on the web-site in a day or two). I assume that after a few
weeks we can see if the fix is safe enough, and then consider porting it
to a 7 update release. Stay tuned.
--
best regards,
Anthony
On 04/26/2013 07:03 PM, Vladimir Kravets wrote:
Thanks a lot, Anthony!
Please let me know when it will be backported to 1.7... As I
understarding it will be backported to 1.7 also. Is it true?
Best Regards,
Vladimir
2013/4/26 Anthony Petrov <[email protected]
<mailto:[email protected]>>
Hi Vladimir,
I've just pushed your fix:
http://hg.openjdk.java.net/__jdk8/awt/jdk/rev/854f60ec4bfb
<http://hg.openjdk.java.net/jdk8/awt/jdk/rev/854f60ec4bfb>
Thank you for contributing the patch!
--
best regards,
Anthony
On 04/25/2013 04:40 PM, Anthony Petrov wrote:
The fix looks good to me as well. If no objections I can push it
to the
AWT repository tomorrow.
--
best regards,
Anthony
On 04/25/13 16:21, Sergey Bylokhov wrote:
Hi, Vladimir.
Fix looks good.
On 24.04.2013 16 <tel:24.04.2013%2016>:40, Vladimir Kravets
wrote:
Hi guys,
Patch was updated according to yours notices.
- Fix copyright in the XWindowPeer
- Add test for such behavior:
* Applicable to Metacity WM
* Cover such behavior:
1. going to fullscreen
2. showing the modal dialog
3. check if dialog appeared above fullscreen
window or not
You can look at it on the same link
http://vkravets.github.io/awt-__fixes/8012586/webrev.00/index.__html
<http://vkravets.github.io/awt-fixes/8012586/webrev.00/index.html>
(webrev original folder can be taken from
https://github.com/vkravets/__awt-fixes/tree/master/8012586
<https://github.com/vkravets/awt-fixes/tree/master/8012586>)
Thanks a lot for cooperative work!
Waiting merging in the master...
Best Regards,
Vladimir
2013/4/23 Sergey Bylokhov <[email protected]
<mailto:[email protected]>
<mailto:Sergey.Bylokhov@__oracle.com
<mailto:[email protected]>>>
Hi, Vladimir.
On 23.04.2013 14:36, Vladimir Kravets wrote:
Hi Sergey,
Could you please point me where I can
do(add/create) this?
It depends on how you write your test.
Location of tests for a full screen mode:
jdk/test/java/awt/FullScreen/
Location of tests for Dialogs:
jdk/test/java/awt/Dialog/
Thanks,
Vladimir
2013/4/23 Sergey Bylokhov
<[email protected]
<mailto:[email protected]>
<mailto:Sergey.Bylokhov@__oracle.com
<mailto:[email protected]>>>
Hello, Vladimir.
Testcase will be welcome, since the issue
was not found by
our regression tests.
On 23.04.2013 12:50, Anthony Petrov wrote:
Thanks Vladimir. The fix looks fine to
me. We need to get
at least one more review, after which
I'll be able to
push it to the repository. Could anyone
review this
please? Here's a link to the webrev:
http://vkravets.github.io/awt-__fixes/8012586/webrev.00/index.__html
<http://vkravets.github.io/awt-fixes/8012586/webrev.00/index.html>
Regarding other WMs and the DIALOG type
- yes, I agree
with you. I don't known of any WMs that
would do
something strange for DIALOG windows,
so as I said this
is just a theoretical concern. The fix
should work fine
now for most WMs. If we encounter a
problem with a
particular WM in the future, we'll see
how to deal with it.
--
best regards,
Anthony
On 04/22/2013 06:33 PM, Vladimir
Kravets wrote:
Done. You can look at the same
link. BTW the full
listing webrev
directory you can find on the
https://github.com/vkravets/__awt-fixes/tree/master/8012586
<https://github.com/vkravets/awt-fixes/tree/master/8012586>
link.
> I assume you have tested this fix
and it works as
expected for your
use cases?
Of course =)
>Although I'm a little concerned
about other window
managers that may
present DIALOG windows somehow
completely differently
(as some Mac-style
sheets for example). In this case
the fix may fail
since it marks
regular owned windows as DIALOGs,
too. This is purely
a theoretical
concern, but still something to
think about.
Shouldn't we check the
window type instead of just
checking whether the
window has an owner or not?
Since this is is not
ICCCM-compliant atom, thus I
guess that all another
WM's should compliant by this spec
from freedesktop.
http://standards.freedesktop.__org/wm-spec/latest/ar01s05.__html#idp1333344
<http://standards.freedesktop.org/wm-spec/latest/ar01s05.html#idp1333344>
In this section very clearly
specified how should
react WM's on
different wndow type. BTW before
fix AWT was not
fully compliant with
this spec =(
Best Regards,
Vladimir
--
Best regards, Sergey.
--
Best regards, Sergey.
--
Best regards, Sergey.
