Good, I'd hoped I could do that :) -DrD-
> > The changes looks fine to me. For JDK8, the fix can be simplified by removing > X11-specific part of jawt_md.h on Mac, since we're going to remove XAWT > support on that platform in JDK8 anyway. > > Thanks, > > Artem > > On 6/6/2013 4:40 PM, Anthony Petrov wrote: >> I've already reviewed this fix, and it looks fine to me. We still need >> another reviewer. Adding awt-dev@. >> >> Anyone please? >> >> -- >> best regards, >> Anthony >> >> On 06/05/13 20:52, David DeHaven wrote: >>> >>> Proposed fix for getting the correct jawt_md.h header in the JDK. I >>> reused the XAWT flag to enable the X11 drawing surface struct. It is >>> disabled by default as just about every application running on Mac >>> will use the Cocoa interface. Apparently the X11 interface is still >>> operable on Mac and it's used for verification, so I don't want to >>> completely remove it just yet. I also changed several #include >>> statements to use the JDK headers instead of the deprecated JavaVM >>> framework headers. >>> >>> Since I'm not a jdk7u-dev committer, Anthony Petrov has graciously >>> agreed to sponsor this patch. I will be kicking off a JPRT run when I >>> can steal another couple minutes, and figure out the magic >>> incantations needed to include the AWT tests. >>> >>> >>> Webrev: >>> http://cr.openjdk.java.net/~ddehaven/7181710/jdk.0/ >>> >>> Issue: >>> http://bugs.sun.com/view_bug.do?bug_id=7181710 >>> >>> -DrD- >>>
