Hi Leonid, thank you a lot for the fix. I have applied the patch to the latest jdk7u40 workspace and noticed that the behaviour is different for Apple and Oracle JDK.
Apple JDK does not highlight the 'FirstMenu' menu in the menu bar, your fix does. I think this is not a big issue as far as native applications like Mail works the same way. Thank you, Denis. On Jul 5, 2013, at 11:18 PM, Leonid Romanov <[email protected]> wrote: > Yes, it does pass with the fix. > > On 7/5/2013 16:20, Sergey Bylokhov wrote: >> Hi, Leonid. >> The test from the bug description (JTextArea + shortcut) is passed after >> the fix? >> >> On 05.07.2013 3:47, Leonid Romanov wrote: >>> Hello, >>> Please review a fix for 8019265: [macosx] apple.laf.useScreenMenuBar >>> regression comparing with jdk6 . The problem here is that >>> NsCharToJavaChar() function we use for translating keystrokes returns >>> CHAR_UNDEFINED for keys like arrows, which is undesirable in case of >>> CMenuItem. >>> >>> bug: http://bugs.sun.com/view_bug.do?bug_id=8019265 >>> webrev: http://cr.openjdk.java.net/~leonidr/8019265/webrev.00/ >>> >>> Thanks, >>> Leonid. >>> >> >> >
