Hi, Alexander. Looks like I found another issue in the fix. PlatformWindow.initialize now uses target.getBounds(). But these bounds are not verifyed against correct values(see LWWP.setBound()) We should rearrange our initialisation code.
======================== Hi, Alexander. The fix looks good. On 12.09.2013 17:14, Alexander Scherbatiy wrote: > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8007219/webrev.01/ > > The problem was that NSWindow is created with zero bounds and then > actual bounds are set. > In this case NSWindow treats big bounds as zoomed state and next > zoom move the window to initial zero bounds. > > The fix sets actual window bounds during NSWindow creation and uses > NSWindow.isZoomed flag instead of CPW.zoomed. > > Thanks, > Alexandr. > > > On 9/11/2013 3:47 PM, Sergey Bylokhov wrote: >> Hi, Alexander. >> Looks like the main issue is that CPW.zoomed and actual state of the >> NSWindow is out of sync. Does unmaximize works after the fix? >> I suggest to remove CPW.zoomed and use NSWindow.isZoomed instead. >> >> On 11.09.2013 15:17, Alexander Scherbatiy wrote: >>> >>> Hello, >>> >>> Could you review the fix: >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007219 >>> webrev: http://cr.openjdk.java.net/~alexsch/8007219/webrev.00 >>> >>> The fix check if an NSWindow is in zoomed state before maximize it. >>> >>> Thanks, >>> Alexandr. >>> >> >> > -- Best regards, Sergey.
