Hi, Alexander.
Method in the GlobalCursorManager can be private or can be removed:

 137     protected Component findComponentAt(Container con, int x, int y){
 138         return AWTAccessor.getContainerAccessor().
 139                 findComponentAt(con, x, y, false);
 140     }

Can you add @Override to the new method in the Container.java?
Also please add copyright to the html file and update dates in the headers.

On 18.09.2013 19:18, Alexander Scherbatiy wrote:

Hello,

Could you review the fix:
  bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007155
  webrev: http://cr.openjdk.java.net/~alexsch/8007155/webrev.00


The findComponent method in the LWCursorManager class searches from a component under the mouse to the parent components and does not take in the account another components under mouse that intersects the disabled one.

The fix adds the necessary findComponentAt method to the container accessor and uses it in the *CursorManager classes.
  The same issues is fixed for the XGlobalCursorManager.
Unnecessary call from native method is removed for the WGlobalCursorManager.

Manual test is added because there is no way to know the actual mouse cursor type.

Thanks,
Alexandr.



--
Best regards, Sergey.

Reply via email to