My understanding is that we agreed we should use the OSInfo in our tests to check the current platform. So let's use it instead of checking toolkit names.

--
best regards,
Anthony

On 09/24/2013 04:06 PM, Konstantin Shefov wrote:

On 24-Sep-13 15:53, Anthony Petrov wrote:
Hi Konstantin,

What is the reason to check the toolkit name as opposed to using the
sun.awt.OSInfo.getOSType() in this case?
This was recommended by the creator of the test Anton Tarasov.

--
best regards,
Anthony

On 09/24/2013 02:51 PM, Konstantin Shefov wrote:
Hello,

Please review a fix for the issue:

  7161320 TEST_BUG:
java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java fails
(Invalid key code)

Test bug fix.

http://bugs.sun.com/view_bug.do?bug_id=7161320

The webrev is: http://cr.openjdk.java.net/~kshefov/7161320/webrev.00

Thanks,
Konstantin

Reply via email to