Hi, Petr.
The fix looks good.
On 23.09.2013 20:22, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8024987
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024987/webrev.01/
This is a regression of the following fix:
https://bugs.openjdk.java.net/browse/JDK-7075105
As a part of that fix the SystemFlavorMap class was refactored. As a part of that
refactoring the nativeToFlavor and flavorToNative cache was updated. Before it was storing
DataFlavor<->String mapping for non-text types and Mime<->String mapping for
text types. After the refactoring it was unified, but some code was not updated, it was
still trying to find a native format in a cache using Mime type, not the DataFlavor. I have
updated that code (see usages of getAllNativesForType: lines 702, 710, 746). Also I have
comletely generified the SystemFlavorMap class, so that such errors could never happen
again.
Testing: netbeans works fine now, I've run all regression test for Clipboard
and datatransfer on Mac and Windows. No new failures.
With best regards. Petr.
--
Best regards, Sergey.
