Hi, Oleg.
The fix looks good.

On 03.10.2013 16:35, Oleg Pekhovskiy wrote:
Hi Sergey, thank you for the review,

please review the second version of fix:
http://cr.openjdk.java.net/~bagiras/8013553.2/

I split the line and added more comments.

Oleg.

On 03.10.2013 15:19, Sergey Bylokhov wrote:
Hi, Oleg.
Can you split the line and add the comment that setExtensionHidden is
not applicable here.

On 03.10.2013 15:08, Leonid Romanov wrote:
Looks good to me.

On 03.10.2013, at 13:07, Oleg Pekhovskiy <[email protected]>
wrote:

Hi all,

please review the fix
http://cr.openjdk.java.net/~bagiras/8013553.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013553

setExtensionHidden(NO) method of NSSavePanel doesn't work as expected
and that's a known issue mentioned on several forums.
But there is another solution based on Application system settings
that allows to control showing of extension for file dialog.

Thanks,
Oleg




--
Best regards, Sergey.

Reply via email to