Hi, I am waiting for a second reviewer. Anthony's remark can be easily fixed. If there are no objections, I will fix bug id in the comment and commit fix.
Andrei ----- Исходное сообщение ----- От: [email protected] Кому: [email protected] Копия: [email protected], [email protected], [email protected] Отправленные: Пятница, 11 Октябрь 2013 г 16:41:47 GMT +04:00 Абу-Даби, Маскат Тема: Re: <AWT Dev> [8] Review Request: JDK-7002846 Fix for 6989505 may be incomplete Hi Andrei, src/windows/classes/sun/awt/windows/WRobotPeer.java > 59 // See 6989505: that's ineffective, but works correctly with > non-opaque windows It'd be more correct to mention 7002846 instead of 6989505 in this comment. The fix looks fine to me otherwise. -- best regards, Anthony On 10/10/2013 03:05 PM, andrei eremeev wrote: > Hello, AWT Team. > > Please review the fix for the issue: > https://bugs.openjdk.java.net/browse/JDK-7002846 > The fix is available at: > http://cr.openjdk.java.net/~yan/jdk-7002846/webrev.00/ > > The problem: WinAPI's function GetPixel returns incorrect value of not > fully opaque pixel on Intel graphic card. > The idea of the fix is to use getPixels(x, y, 1, 1)[0] which gets pixels > correctly. But this solution is 2 times slower than we had.
