Looks good. -- best regards, Anthony
On 11/20/2013 05:26 PM, Sergey Bylokhov wrote:
Hello. Please review the fix for jdk 8. Crash is occurred in ExitFullSCreen, because env is used in asynchronous call on appkit. Also code related to the setDisplayMode was updated, because before the fix of JDK-8013581 we have to exit/enter fullscreen to reapply size of the screen to the window(double exits were noop in case of nsview based fullscreen). And new code in 8013581 is not ready to the double exits. Bug: https://bugs.openjdk.java.net/browse/JDK-8028512 Webrev can be found at: http://cr.openjdk.java.net/~serb/8028512/webrev.00