Hello, Roger. The fix looks good to me.
With best regards. Petr. On 03.12.2013, at 2:53, roger riggs <[email protected]> wrote: > Hi Yuri, > > I updated the webrev to remove conflicts with the changeset in the 2D > repository. > I will push on Tuesday based on your OK comment unless I hear otherwise. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-lint-awt-8028019/ > > Thanks, Roger > > On 11/28/2013 3:32 AM, Yuri Nesterenko wrote: >> >> On 11/27/2013 08:15 PM, roger riggs wrote: >>> Hi Yuri, >>> >>> I don't see a spacing difference between <br> and no markup. >>> <br> is supposed only to terminate the line, not add any spacing >>> and I did not see any difference in an example I tried. >>> Perhaps you would point me to a specific example. >> >> Uhm, Roger, you are right. In your files that "p" seems to be always >> somewhere before "@see" which is wrapped in "div" by javadoc. >> >> So, the fix is OK with me. >> Please try to avoid merge in 2D code with 4592f0985e78 (in 2D team >> repository since Nov.20, JDK-8025235). >> >>> >>> The formatting should be handled by the stylesheets and adding extra >>> markup to affect the presentation is not the best approach. >> That's always true but we don't control stylelesheets. >> >> Thanks, >> -yan >
