Hi Alexander,
1. Please add your evaluation to the bug report.
2. In gtk2_interface.c: can we declare the i variable somewhere closer
to where it is used? What's the point with all these forward
declarations? We don't compile with C89, do we?
3. Checking for http: to enable the BROWSE action looks reasonable to
me. And I suggest to check for the mailto: scheme separately, so that
the MAIL action is only enabled if it's supported.
4.
534 #ifdef __solaris__
535 update_supported_actions(env);
536 #endif
Have you tested this on Linux with your patch applied? How is the list
of supported actions supposed to be populated on that platform?
5. In XDesktopPeer.java: please move the comment at line 51 above the
field that it describes.
--
best regards,
Anthony
On 12/12/2013 09:03 PM, Alexander Zvegintsev wrote:
Hello AWT team,
Please review fix
http://cr.openjdk.java.net/~azvegint/jdk/8/8029263/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8029263
This issue can be observed on Solaris 11 (sparcv9 or x86_64).
gtk_show_uri() documentation[1] says:
The uri must be of a form understood by GIO (i.e. you need to install
gvfs to get support for uri schemes such as http:// or ftp://, as only
local files are handled by GIO itself).
However it looks like that Solaris 11 supports gvfs for 32-bit
applications only by default. gtk_show_uri() returns "Operation not
supported" error message for 64-bit applications
for schemes other than file://.
Since b110 we don't have 32-bit JDK for Solaris anymore, so in most
cases only an OPEN action is available(file://).
Currently I am unable to find any robust way to determine do we have
full gvfs support to handle URIs like mail:, http:// or not.
We can use g_vfs_get_supported_uri_schemes()[2] and assume that we have
full gvfs support if http:// scheme is present.
But this function depends on a DBUS_SESSION_BUS_ADDRESS environment
variable, which can be stripped off in some tests
(in this case only file:// scheme will be returned).
Old gnome_url_show() will not work too due to lack of 64-bit
libgnomevfs-2.0 library.
[1]
https://developer.gnome.org/gtk2/stable/gtk2-Filesystem-utilities.html#gtk-show-uri
[2]
https://developer.gnome.org/gio/stable/GVfs.html#g-vfs-get-supported-uri-schemes
--
Thanks,
Alexander.
