On 09.01.2014 23:56, Joe Darcy wrote:
Hello Sergey,
On 1/8/2014 11:53 PM, Sergey Bylokhov wrote:
Hello, Joe.
Why @see tag was removed in the ComponentPeer.java?
Because they were resulting in "error: reference not found" messages.
The syntax appears correct, but the error is generated anyway. Since
the peer package doesn't seem to be included in the main doc bundle, I
didn't think removing the @see tags would be that much of a loss of
functionality.
I suppose too, but I think a separate issue should be filed on doclint.
Anyway the fix looks good, but note that the new year in headers should
be 2014.
In the JLabel.java @exception was removed is this change of
specifications?
The @exception tag was for an unchecked exception and was blank;
removing it is not a specification change since it doesn't specify
anything ;-)
It would be good to split the changed line in the MouseInfoPeer.java.
Reformatted. Updated webrev:
http://cr.openjdk.java.net/~darcy/8031082.1/
Thanks,
-Joe
On 09.01.2014 5:08, Joseph Darcy wrote:
Happy new year!
Happy new year!
In case this was overlooked during the new year's holiday, please
look over the changes in
http://cr.openjdk.java.net/~darcy/8031082.0/
which resolve many of the outstanding doclint issues in the client
libraries.
Thanks,
-Joe
On 12/31/2013 12:51 AM, Joe Darcy wrote:
Hello,
Please review my fix for
JDK-8031082 Fix non-missing doclint problems in client libraries
The fix resolves nearly all of the outstanding doclint issues in
the client libraries, others than the missing javadoc tags. The
affected files are
src/share/classes/java/awt/Graphics2D.java
src/share/classes/java/awt/MediaTracker.java
src/share/classes/java/awt/font/TextAttribute.java
src/share/classes/java/awt/peer/ComponentPeer.java
src/share/classes/java/awt/peer/DialogPeer.java
src/share/classes/java/awt/peer/KeyboardFocusManagerPeer.java
src/share/classes/java/awt/peer/MouseInfoPeer.java
src/share/classes/java/awt/peer/PanelPeer.java
src/share/classes/java/awt/peer/TextAreaPeer.java
src/share/classes/java/awt/peer/WindowPeer.java
src/share/classes/java/awt/print/Paper.java
src/share/classes/java/awt/print/Printable.java
src/share/classes/java/beans/XMLEncoder.java
src/share/classes/javax/accessibility/AccessibleContext.java
src/share/classes/javax/imageio/ImageWriter.java
src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java
src/share/classes/javax/imageio/stream/ImageInputStream.java
src/share/classes/javax/imageio/stream/ImageOutputStream.java
src/share/classes/javax/print/Doc.java
src/share/classes/javax/print/DocFlavor.java
src/share/classes/javax/print/MultiDoc.java
src/share/classes/javax/print/MultiDocPrintJob.java
src/share/classes/javax/print/ServiceUI.java
src/share/classes/javax/print/StreamPrintServiceFactory.java
src/share/classes/javax/print/attribute/AttributeSet.java
src/share/classes/javax/print/attribute/standard/Chromaticity.java
src/share/classes/javax/print/attribute/standard/Copies.java
src/share/classes/javax/print/attribute/standard/Fidelity.java
src/share/classes/javax/print/attribute/standard/Finishings.java
src/share/classes/javax/print/attribute/standard/JobKOctets.java
src/share/classes/javax/print/attribute/standard/JobState.java
src/share/classes/javax/print/attribute/standard/MediaName.java
src/share/classes/javax/print/attribute/standard/MediaSize.java
src/share/classes/javax/print/attribute/standard/MediaSizeName.java
src/share/classes/javax/print/attribute/standard/MediaTray.java
src/share/classes/javax/print/attribute/standard/MultipleDocumentHandling.java
src/share/classes/javax/print/attribute/standard/NumberUp.java
src/share/classes/javax/print/attribute/standard/PageRanges.java
src/share/classes/javax/print/attribute/standard/PrinterMoreInfoManufacturer.java
src/share/classes/javax/print/attribute/standard/PrinterResolution.java
src/share/classes/javax/print/attribute/standard/SheetCollate.java
src/share/classes/javax/print/attribute/standard/Sides.java
src/share/classes/javax/sound/sampled/AudioInputStream.java
src/share/classes/javax/sound/sampled/AudioPermission.java
src/share/classes/javax/sound/sampled/ReverbType.java
src/share/classes/javax/swing/DefaultComboBoxModel.java
src/share/classes/javax/swing/JComboBox.java
src/share/classes/javax/swing/JEditorPane.java
src/share/classes/javax/swing/JLabel.java
src/share/classes/javax/swing/JLayeredPane.java
src/share/classes/javax/swing/JOptionPane.java
src/share/classes/javax/swing/JTextArea.java
src/share/classes/javax/swing/JTextPane.java
src/share/classes/javax/swing/plaf/TextUI.java
src/share/classes/javax/swing/plaf/basic/BasicTextUI.java
src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java
src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java
src/share/classes/javax/swing/text/CompositeView.java
src/share/classes/javax/swing/text/DefaultEditorKit.java
src/share/classes/javax/swing/text/Document.java
src/share/classes/javax/swing/text/GlyphView.java
src/share/classes/javax/swing/text/JTextComponent.java
src/share/classes/javax/swing/text/NavigationFilter.java
src/share/classes/javax/swing/text/html/HTMLDocument.java
src/share/classes/javax/swing/text/html/StyleSheet.java
and the full webrev is hosted at
http://cr.openjdk.java.net/~darcy/8031082.0/
Thanks,
-Joe
--
Best regards, Sergey.
