Hi Sergey,
The fix looks good. However, please rephrase the comment in
XRepaintArea, because it may sound confusing when read later w/o knowing
the context. I'd suggest something like the following:
We shouldn't call peer.paintPeer() when processing UPDATE events.
--
best regards,
Anthony
On 1/17/2014 3:54 PM, Sergey Bylokhov wrote:
Hello.
New jdk 9 review request for 7157680:
This fix is for xawt, the same bug was already fixed in lwawt JDK-7125657.
According of
http://www.oracle.com/technetwork/java/painting-140037.html# update()
can be used for Incremental painting. And as example this tutorial
provide this demo:
http://www.comp.nus.edu.sg/~cs3283/ftp/Java/swingConnect/special_report/painting/UpdateDemo.java
It accidentally work in a xawt, because XCanvasPeer.paintPeer() is noop,
but if Canvas will be replaced by the Label in the demo, then
incremental version of the demo does not work.
Bug: https://bugs.openjdk.java.net/browse/JDK-7157680
Webrev can be found at: http://cr.openjdk.java.net/~serb/7157680/webrev.00
On 17.10.2013 22:13, Anthony Petrov wrote:
Hi Sergey,
I believe this fix belongs to early builds of JDK 9.
--
best regards,
Anthony
On 10/17/2013 01:51 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 8.
This fix is for xawt, the same bug was already fixed in lwawt
JDK-7125657.
According of
http://www.oracle.com/technetwork/java/painting-140037.html# update()
can be used for Incremental painting. And as example this tutorial
provide this this demo:
http://www.comp.nus.edu.sg/~cs3283/ftp/Java/swingConnect/special_report/painting/UpdateDemo.java
It accidentally work in a xawt, because XCanvasPeer.paintPeer() is noop,
but if Canvas will be replaced by the Label in the demo, then
incremental version of the demo does not work.
Bug: https://bugs.openjdk.java.net/browse/JDK-7157680
Webrev can be found at:
http://cr.openjdk.java.net/~serb/7157680/webrev.00
