Hello, Sergey. The fix looks good to me.
With best regards. Petr. On 27.01.2014, at 15:42, Sergey Bylokhov <[email protected]> wrote: > I added @Override, because it make code refactoring safer. > I have separate CR for lamdafication > https://bugs.openjdk.java.net/browse/JDK-8031781 > > On 27.01.2014 14:42, Artem Ananiev wrote: >> >> Since you're adding @Override in many places, didn't you think about >> replacing some of the inner Runnable classes with lambdas? >> >> Thanks, >> >> Artem >> >> On 1/24/2014 6:49 PM, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for jdk 9. >>> This is cleanup of the sun.awt.windows package: >>> - Encapsulation strengthening. >>> - final and @Override were added whenever possible. >>> - WPrintDialog now uses AWTAccessor instead of its own setPeer() >>> native method. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8032435 >>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8032435/webrev.00 >>> > > > -- > Best regards, Sergey. >
