Hello, Joe. The fix looks good.
> assuming of course they don't leak into the serialized stream of a supported > type. These classes are related to the AppletViewer, so they should not. With best regards. Petr. On 12.03.2014, at 11:29, Alan Bateman <alan.bate...@oracle.com> wrote: > > cc'ing awt-dev as this where the Applet code is maintained. > > In any case, the suppressing of serial warnings looks okay to me, assuming of > course they don't leak into the serialized stream of a supported type. > > -Alan. > > On 12/03/2014 06:18, Joe Darcy wrote: >> Hello, >> >> Please review the patch below to address >> >> JDK-8037174: Fix serial lint warnings in sun.applet >> http://cr.openjdk.java.net/~darcy/8037174.0/ >> >> Thanks, >> >> -Joe >> >> --- old/src/share/classes/sun/applet/AppletEvent.java 2014-03-11 >> 23:15:49.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletEvent.java 2014-03-11 >> 23:15:49.000000000 -0700 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1997, Oracle and/or its affiliates. All rights reserved. >> + * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -33,7 +33,7 @@ >> * >> * @author Sunita Mani >> */ >> - >> +@SuppressWarnings("serial") // JDK-implementation class >> public class AppletEvent extends EventObject { >> >> private Object arg; >> --- old/src/share/classes/sun/applet/AppletIOException.java 2014-03-11 >> 23:15:49.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletIOException.java 2014-03-11 >> 23:15:49.000000000 -0700 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1996, Oracle and/or its affiliates. All rights reserved. >> + * Copyright (c) 1996, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -32,6 +32,7 @@ >> * >> * @author Koji Uno >> */ >> +@SuppressWarnings("serial") // JDK implementation class >> public >> class AppletIOException extends IOException { >> private String key = null; >> --- old/src/share/classes/sun/applet/AppletIllegalArgumentException.java >> 2014-03-11 23:15:50.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletIllegalArgumentException.java >> 2014-03-11 23:15:50.000000000 -0700 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1996, Oracle and/or its affiliates. All rights reserved. >> + * Copyright (c) 1996, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -30,6 +30,7 @@ >> * >> * @author Arthur van Hoff >> */ >> +@SuppressWarnings("serial") // JDK implementation class >> public >> class AppletIllegalArgumentException extends IllegalArgumentException { >> private String key = null; >> --- old/src/share/classes/sun/applet/AppletPanel.java 2014-03-11 >> 23:15:50.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletPanel.java 2014-03-11 >> 23:15:50.000000000 -0700 >> @@ -62,6 +62,7 @@ >> * >> * @author Arthur van Hoff >> */ >> +@SuppressWarnings("serial") // JDK implementation class >> public >> abstract class AppletPanel extends Panel implements AppletStub, Runnable { >> >> --- old/src/share/classes/sun/applet/AppletProps.java 2014-03-11 >> 23:15:51.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletProps.java 2014-03-11 >> 23:15:51.000000000 -0700 >> @@ -37,6 +37,7 @@ >> >> import sun.security.action.*; >> >> +@SuppressWarnings("serial") // JDK implementation class >> class AppletProps extends Frame { >> >> TextField proxyHost; >> @@ -194,7 +195,7 @@ >> >> /* 4066432 */ >> /* Dialog class to display property-related errors to user */ >> - >> +@SuppressWarnings("serial") // JDK implementation class >> class AppletPropsErrorDialog extends Dialog { >> public AppletPropsErrorDialog(Frame parent, String title, String message, >> String buttonText) { >> --- old/src/share/classes/sun/applet/AppletSecurityException.java 2014-03-11 >> 23:15:51.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletSecurityException.java 2014-03-11 >> 23:15:51.000000000 -0700 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1995, 1998, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 1995, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -30,6 +30,7 @@ >> * >> * @author Arthur van Hoff >> */ >> +@SuppressWarnings("serial") // JDK-implementation class >> public >> class AppletSecurityException extends SecurityException { >> private String key = null; >> --- old/src/share/classes/sun/applet/AppletViewer.java 2014-03-11 >> 23:15:52.000000000 -0700 >> +++ new/src/share/classes/sun/applet/AppletViewer.java 2014-03-11 >> 23:15:52.000000000 -0700 >> @@ -46,6 +46,7 @@ >> /** >> * A frame to show the applet tag in. >> */ >> +@SuppressWarnings("serial") // JDK-implementation class >> class TextFrame extends Frame { >> >> /** >> @@ -115,6 +116,7 @@ >> * (The document named appletviewertags.html in the JDK's docs/tooldocs >> directory, >> * once the JDK docs have been installed.) >> */ >> +@SuppressWarnings("serial") // JDK implementation class >> public class AppletViewer extends Frame implements AppletContext, >> Printable { >> >> --- old/src/share/classes/sun/applet/Main.java 2014-03-11 >> 23:15:52.000000000 -0700 >> +++ new/src/share/classes/sun/applet/Main.java 2014-03-11 >> 23:15:52.000000000 -0700 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -512,6 +512,7 @@ >> return amh.getMessage(key, arg0, arg1, arg2); >> } >> >> + @SuppressWarnings("serial") // JDK implementation class >> class ParseException extends RuntimeException >> { >> public ParseException(String msg) { >> >
