Hi,Petr.
The fix looks good. Thanks!
On 13.03.2014 19:45, Petr Pchelko wrote:
Hello, AWT Team.
Please review a huge but simple cleanup fix.
The bug: https://bugs.openjdk.java.net/browse/JDK-8037099
The fix: http://cr.openjdk.java.net/~pchelko/9/8037099/webrev.01
Now the Objective-C Garbage Collector is completely deprecated and we do not
use it and will never use. But we still have some code that was used for GC.
The problem is that under GC retain/release is not the same as
CFRetain/CFRelease, but now it's absolutely the same.
I've replaced all CFRetain/CFRelease to retain/release where possible, deleted
the pattern CFRetain(o); [o release]; and removed finalize overrides.
I know that in some places retain is not needed. But in this fix I've left it
as is, because it's only a preparation for a big-native-memory-management-fix
I'm preparing.
Thank you.
With best regards. Petr.
--
Best regards, Sergey.
