Hi, Petr.
A few notes:
314 if (prevDataFlavors != null && currentDataFlavors != null
315 && prevDataFlavors.equals(currentDataFlavors)) {
316 return;
317 }
I suppose we should return in case both of them will be null?
Objects.equals should be a little bit more readable here.
440 flavorListeners.stream()
441 .filter(Objects::nonNull)
442 .forEach(listener ->
SunToolkit.postEvent(appContext,
443 new PeerEvent(this,
444 () -> listener.flavorsChanged(new
FlavorEvent(SunClipboard.this)),
445 PeerEvent.PRIORITY_EVENT)));
here is a place where we can reformat it to be more readable.
On 18.03.2014 18:34, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-6463901
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/6463901/webrev/
The bug states that we should deprecate or generify the EventListenerAggregate
class.
However it's an internal class in sun.awt package so we could remove it.
I've used grep on JDK source to verify that this class is not used any more.
Clipboard regression, functional and JCK tests run fine.
With best regards. Petr.
--
Best regards, Sergey.
