Hello, Sergey. Thank you for the clarification.
The fix looks good to me. With best regards. Petr. On 08.04.2014, at 13:53, Sergey Bylokhov <[email protected]> wrote: > On 4/8/14 12:49 PM, Petr Pchelko wrote: >> Hello, Sergey. >> >> Why don't you add a boolean parameter to syncNativeQueue to avoid adding a >> new native method? > Two reasons: > - syncNativeQueue will be reworked in the future, since it does not work > correctly in all cases now. > - If syncNativeQueue() will be reused, when I'll have to ignore its timeout > parameter, this can be misleading >> >> With best regards. Petr. >> >> On 07.04.2014, at 23:23, Sergey Bylokhov <[email protected]> wrote: >> >>> Hello. >>> Please review the fix for jdk 9. >>> In the fix Toolkit.sync() is implemented in the same way as on other >>> platforms. Note that on OSX we need additional step to flush the native >>> selectors queue, because all our rendering was done to offscreen texture. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8038765 >>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8038765/webrev.00 >>> >>> -- >>> Best regards, Sergey. >>> > > > -- > Best regards, Sergey. >
